Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tcgc] handle orphan types in nested namespaces #1558

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

tadelesh
Copy link
Member

fix: #1531

@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 18, 2024

All changed packages have been documented.

  • @azure-tools/typespec-azure-resource-manager
  • @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-azure-resource-manager - feature ✏️

x-ms-skip-url-encoding should be replaced with allowReserved

@azure-tools/typespec-client-generator-core - breaking ✏️

  1. The kind for unknown renamed from any to unknown.,> 2. The values property in SdkUnionType renamed to variantTypes.,> 3. The values property in SdkTupleType renamed to valueTypes.,> 4. The example types for parameter, response and SdkType has been renamed to XXXExampleValue to emphasize that they are values instead of the example itself.,> 5. The @format decorator is no longer able to change the type of the property.

@azure-tools/typespec-client-generator-core - fix ✏️

Fix naming logic for anonymous model wrapped by HttpPart

@azure-tools/typespec-client-generator-core - fix ✏️

Fix subscriptionId for ARM SDK

@azure-tools/typespec-client-generator-core - fix ✏️

handle orphan types in nested namespaces

@azure-tools/typespec-client-generator-core - fix ✏️

fix onClient setting for client initialization parameters applied to an interface

@azure-tools/typespec-client-generator-core - breaking ✏️

  1. change encode in SdkBuiltInType to optional.,> 2. no longer use the value of kind as encode when there is no encode on this type.

@azure-tools/typespec-client-generator-core - breaking ✏️

no longer export the SdkExampleValueBase interface. This type should have no usage in downstream consumer's code. If there is any usage, please replace it with SdkExampleValue.

@iscai-msft iscai-msft merged commit 354be86 into release/september-2024 Sep 18, 2024
20 of 22 checks passed
@iscai-msft iscai-msft deleted the handle-orphan-model-in-nested-ns branch September 18, 2024 14:40
markcowl pushed a commit to markcowl/typespec-azure that referenced this pull request Sep 24, 2024
markcowl pushed a commit to markcowl/typespec-azure that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants