Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tcgc] change example mapping logic to allow operation id with/without renaming #1592

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

tadelesh
Copy link
Member

@tadelesh tadelesh commented Sep 24, 2024

fix: #1593

@azure-sdk
Copy link
Collaborator

All changed packages have been documented.

  • @azure-tools/typespec-azure-resource-manager
  • @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-azure-resource-manager - feature ✏️

x-ms-skip-url-encoding should be replaced with allowReserved

@azure-tools/typespec-client-generator-core - fix ✏️

change example mapping logic to allow operation id with/without renaming

@azure-tools/typespec-client-generator-core - fix ✏️

In 0.46.1 we changed the type of responses in SdkHttpOperation from Map<number | HttpRange, SdkHttpResponse> to SdkHttpResponse[], exceptions in SdkHttpOperation from Map<number | HttpRange | "*", SdkHttpResponse> to SdkHttpResponse[],,> and added a statusCodes property to SdkHttpResponse. But the statusCodes is defined as number | HttpRange | "*", which loses the information that the responses in responses property could never have a * as its statusCodes.,> This PR adds a new type SdkHttpErrorResponse with the statusCodes of number | HttpRange | "*", and changes the type of statusCodes in SdkHttpResponse to number | HttpRange to be precise.

@tadelesh tadelesh enabled auto-merge (squash) September 24, 2024 07:07
@tadelesh tadelesh merged commit fd4144c into release/september-2024 Sep 24, 2024
20 of 22 checks passed
@tadelesh tadelesh deleted the fix_example_mapping branch September 24, 2024 07:13
markcowl pushed a commit to markcowl/typespec-azure that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants