Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @access and @usage support for named union #413

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Add @access and @usage support for named union #413

merged 5 commits into from
Mar 13, 2024

Conversation

tadelesh
Copy link
Member

resolve: #403
Also add deprecation doc.

@azure-sdk
Copy link
Collaborator

All changed packages have been documented.

@azure-sdk
Copy link
Collaborator

@@ -92,6 +92,8 @@ extern dec client(target: Namespace | Interface, value?: {}, scope?: valueof str
extern dec operationGroup(target: Namespace | Interface, scope?: valueof string);

/**
* DEPRECATED: Use `@usage` and `@access` decorator instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to mark them explicitly as deprecated instead of just a comment that most people don't read?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timotheeguerin they've already been previously marked as deprecated. They've been deprecated for a while, is it fair for us to remove support for it now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have still never removed any deprecated element from typespec but for tcgc probably ok if you do as it shouldn't be used in RPSaaSmaster yet and otherwise it would have already failed

@iscai-msft iscai-msft enabled auto-merge (squash) March 13, 2024 17:59
@iscai-msft iscai-msft merged commit 53a985f into main Mar 13, 2024
14 checks passed
@iscai-msft iscai-msft deleted the fix-tcgc branch March 13, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Named union should support @usage and @access in TCGC
4 participants