[tcgc] change response structure to mapping with key number, status code range, or * #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HttpOperationResponse
that@typespec/http
returns to us has property.statusCodes
on each of them. The type of this isHttpStatusCodeRange | number | "*"
. On the tcgc side, we're creating a map to more easily map status codes to the expected responses. We used to map this as aRecord
ofnumber | string
(we would do some processing magic for status codes). However, we've decided to switch to aMap
since it can handle complex key inputs, and made the key inputs the same as the.statusCodes
type fromtsp
for fidelity.All instances of passing the responses to
Object.keys(responses)
/Object.values(responses)
/Object.items(responses)
should be changed, and you can directly access the native.keys(responses)
etc