-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCGC common layer refine #517
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadelesh
requested review from
lmazuel,
m-nash,
iscai-msft,
srnagar,
joheredi,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
March 26, 2024 09:44
All changed packages have been documented. |
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/517/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/517/ |
tadelesh
changed the title
fix wrong union
TCGC common layer refine
Mar 28, 2024
generatedName
flag and refine templated model naming
timotheeguerin
approved these changes
Mar 28, 2024
Co-authored-by: Timothee Guerin <[email protected]>
…ix_tcgc_type_issue
archerzz
approved these changes
Mar 29, 2024
…ix_tcgc_type_issue
…ec-azure into fix_tcgc_type_issue
…ec-azure into fix_tcgc_type_issue
…ix_tcgc_type_issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generatedName
flagSdkEnumValueType.valueType
should beSdkBuiltInType
#541