[Autorest-canonical Emitter] Update resolveRef for the common type dir #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinwa-ms
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
timotheeguerin
requested changes
Apr 15, 2024
timotheeguerin
approved these changes
Apr 17, 2024
auto-merge was automatically disabled
April 19, 2024 16:21
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tested the autorest-canonical emitter in this PR and it failed due to setting the common types. Update the emitter with logic to getSchemaOrRef and resolveRef to correctly set the common type dir.