Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making mixin model names to have consistent `Property" suffix #768

Merged
merged 6 commits into from
May 7, 2024

Conversation

allenjzhang
Copy link
Member

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 1, 2024

All changed packages have been documented.

  • @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-azure-resource-manager - deprecation ✏️

Standardizing mix-in model names with consistent Property suffix.,> ,> - Deprecate ManagedServiceIdentity. ManagedServiceIdentityProperty should be used instead.,> ,> Example:,> diff,> -...ManagedServiceIdentity;,> +...ManagedServiceIdentityProperty;,> ,> ,> - Deprecate ManagedSystemAssignedIdentity. ManagedSystemAssignedIdentityProperty should be used instead.,> ,> Example:,> diff,> -...ManagedSystemAssignedIdentity;,> +...ManagedSystemAssignedIdentityProperty;,> ,> ,> - Deprecate EntityTag. EntityTagProperty should be used instead.,> ,> Example:,> diff,> -...EntityTag;,> +...EntityTagProperty;,> ,> ,> - Deprecate ResourceKind. ResourceKindProperty should be used instead.,> ,> Example:,> diff,> -...ResourceKind;,> +...ResourceKindProperty;,> ,> ,> - Deprecate ResourcePlan. ResourcePlanProperty should be used instead.,> ,> Example:,> diff,> -...ResourcePlan;,> +...ResourcePlanProperty;,> ,> ,> - Deprecate ResourceSku. ResourceSkuProperty should be used instead.,> ,> Example:,> diff,> -...ResourceSku;,> +...ResourceSkuProperty;,> ,> ,> - Deprecate ManagedBy. ManagedByProperty should be used instead.,> ,> Example:,> diff,> -...ManagedBy;,> +...ManagedByProperty;,>

@azure-sdk
Copy link
Collaborator

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. We need to look at the getting started docs and the how to docs in another PR to make sure this is reflected there as well.

@allenjzhang
Copy link
Member Author

This looks good. We need to look at the getting started docs and the how to docs in another PR to make sure this is reflected there as well.

#773 filed

@allenjzhang allenjzhang added this pull request to the merge queue May 7, 2024
Merged via the queue into Azure:main with commit 7cf57c6 May 7, 2024
21 checks passed
@allenjzhang allenjzhang deleted the azhang_managedIdentity branch May 7, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants