Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to MSAL 1.29+'s TokenCache.search() #131

Closed
wants to merge 1 commit into from
Closed

Switch to MSAL 1.29+'s TokenCache.search() #131

wants to merge 1 commit into from

Conversation

rayluo
Copy link
Contributor

@rayluo rayluo commented May 2, 2024

This PR will only work when this MSAL PR is merged and shipped (possibly in version 1.29).

CC @jiasli

@musicinmybrain
Copy link
Contributor

MSAL 1.29 has shipped, with the necessary PR.

@musicinmybrain
Copy link
Contributor

Note that the release notes say that TokenCache.search() returns a generator, while a compatibility TokenCache.find() (not TokenCache._find()!) returns a list and produces a DeprecationWarning.

@rayluo rayluo closed this Jun 23, 2024
@rayluo rayluo deleted the search branch June 23, 2024 01:36
@rayluo rayluo restored the search branch June 23, 2024 01:38
@rayluo
Copy link
Contributor Author

rayluo commented Jun 23, 2024

@musicinmybrain , you have sharp eyes to notice that MSAL 1.29 was released just hours ago!

Don't worry. We are also shipping the MSAL Extensions 1.2.0 soon. UPDATE: Shipped!

@jiasli
Copy link
Contributor

jiasli commented Jun 24, 2024

I saw this PR got superseded by 6fd4920.

Just a kind reminder that it is better to make the _find -> search change and version bump in separate PRs. Consider you need to revert this _find -> search change but not the version bump. Separate PRs can be handy in such situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants