Device code flow fixes when broker is enabled #4846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashok672
changed the title
src/client/Microsoft.Identity.Client/Cache/Items/MsalAccountCacheItem.cs
Show resolved
Hide resolved
neha-bhargava
approved these changes
Jul 17, 2024
fengga
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
I was not in the conversation of how to fix the issue. The code is aligned with the description "WAM does not support device code flow so mark the account with account source to indicate device code flow constructed this account and never go to WAM for subsequent silent token calls", LGTM.
bgavrilMS
reviewed
Jul 18, 2024
| /// The initial flow that established the account. For example, device code flow. | ||
| /// </summary> | ||
| /// <remarks>Can be null. Currently only device code flow updates this property with a valid string</remarks> | ||
| string AccountSource { get; } |
There was a problem hiding this comment.
This is a breaking change. You can't add properties to an interface. Please do not ship this.
There was a problem hiding this comment.
IMO this should not be added to the public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4786
Changes proposed in this request
Testing
Integration test added.
Also tested manually using the device code flow functionality added to the test app.
Performance impact
Negligible. Just an extra account property to read from and write to the cache.