Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 15 support #5410

Closed
jerone opened this issue Nov 21, 2022 · 99 comments
Closed

Angular 15 support #5410

jerone opened this issue Nov 21, 2022 · 99 comments
Assignees
Labels
feature Feature requests. msal-angular Related to @azure/msal-angular package public-client Issues regarding PublicClientApplications tracked-internally Bugs that are tracked by Msft internally

Comments

@jerone
Copy link
Contributor

jerone commented Nov 21, 2022

Core Library

MSAL.js v2 (@azure/msal-browser)

Core Library Version

Latest

Wrapper Library

MSAL Angular (@azure/msal-angular)

Wrapper Library Version

Latest

Public or Confidential Client?

Public

Description

Will MSAL support Angular 15.

MSAL Configuration

No response

Relevant Code Snippets

No response

Identity Provider

No response

Source

External (Customer)

@jerone jerone added the question Customer is asking for a clarification, use case or information. label Nov 21, 2022
@ghost ghost added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Nov 21, 2022
@github-actions github-actions bot added msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications labels Nov 21, 2022
@ghost ghost assigned sameerag Nov 21, 2022
@YanerTavuz
Copy link

i think that since Ivy is required in Angular v15, then this is connected to #4298 maybe?

@sameerag
Copy link
Member

@jerone We are in the process of adding Angular 15 support. We have started tracking it internally and someone will start looking into this actively soon. I do not have a specific ETA yet but will be prioritized as soon as we can. cc @EmLauber

@ghost ghost added answered Question has received "first qualified response" Needs: Author Feedback Awaiting response from issue author and removed Needs: Attention 👋 Awaiting response from the MSAL.js team labels Nov 22, 2022
@sameerag sameerag added feature Feature requests. Needs: Attention 👋 Awaiting response from the MSAL.js team and removed answered Question has received "first qualified response" Needs: Author Feedback Awaiting response from issue author labels Nov 22, 2022
@ghost ghost removed question Customer is asking for a clarification, use case or information. Needs: Attention 👋 Awaiting response from the MSAL.js team labels Nov 22, 2022
@sameerag sameerag added question Customer is asking for a clarification, use case or information. Needs: Attention 👋 Awaiting response from the MSAL.js team tracked-internally Bugs that are tracked by Msft internally and removed Needs: Attention 👋 Awaiting response from the MSAL.js team labels Nov 22, 2022
@sameerag sameerag removed their assignment Nov 28, 2022
@peterzenz
Copy link
Contributor

Assigning to @EmLauber for tracking. This should get picked up in Q1 2023.

@ghost ghost added answered Question has received "first qualified response" Needs: Author Feedback Awaiting response from issue author labels Dec 21, 2022
@aylmercarson
Copy link

aylmercarson commented Dec 26, 2022

stopped me dead in my tracks after promoting azure B2C and Angular. hard to believe that MS can't/won't keep up with the NG release cycle given the HUGE number of corporate integrations there are.

@ghost
Copy link

ghost commented Jan 1, 2023

@jerone This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale.

@ghost ghost added the no-issue-activity Issue author has not responded in 5 days label Jan 1, 2023
@mtosic
Copy link

mtosic commented May 9, 2023

Angular 16 sample

Yes you can see the PR the team is working on for an Angular 16 sample. If you'd like, you can "Subscribe" directly to the PR and be notified immediately when it is merged instead of waiting for me to update this thread.

Hi @EmLauber, I wanted to create an issue, but there is no option for selecting v3 of MSAL-Angular.

As for Angular 16 sample, it would be great if you could also make "standalone" sample. In Angular v16, there is even an option in CLI "ng new --standalone" which completely removes modules when creating new Angular app.

@EmLauber
Copy link
Contributor

EmLauber commented May 9, 2023

For those that experienced yarn or other package manager issues, v3 alpha-1 is out and should address those problems.

no option for selecting v3 of MSAL-Angular.

We are updating our drop downs. For now you can just enter the version as v3 alpha in the version field for the wrapper.

make "standalone" sample

I'll pass along this feedback. Our priority is validating v3 and existing sample works with Angular 16, then we can iterate on other samples for Angular 16.

@grosch-intl
Copy link

For those that experienced yarn or other package manager issues, v3 alpha-1 is out and should address those problems.

Thank you!

@dansau84
Copy link

what is the solution or partial workaround for this error about angular and msal version incompatibility.

@grosch-intl
Copy link

@dansau84 The temporary workaround I'm doing is just adding this to my package.json:

  "dependencies": {
    "@azure/msal-angular": "3.0.0-alpha.2",
    "@azure/msal-browser": "3.0.0-alpha.2",
    ...
  },
  "resolutions": {
    "@azure/msal-browser": "3.0.0-alpha.2"
  },
  "overrides": {
    "@azure/msal-browser": "3.0.0-alpha.2"
  }

That way both npm and yarn will grab that specific version I want.

@alexander-kastil
Copy link

alexander-kastil commented Jun 6, 2023

Not having an msal package that is ivy compatible is a showstopper for Angular 16 migration as ngcc was removed. Microsoft is aware of this problem for at least 3-4 months. Still you seem to have all the time in the world … I really have to state that this is a very poor performance for an enterprise auth system like Azure AD … verry disappointing 🤬

@alex737876
Copy link

@EmLauber Could you please give a short feedback on the current state? :)

@EmLauber
Copy link
Contributor

EmLauber commented Jun 6, 2023

Ivy support is available in our latest major release, MSAL.Angular v3. The release is still in alpha as we gather feedback and we are releasing updates with that feedback. You can help us by testing v3 alpha and creating new issues for any bugs you find. I am leaving this issue about Angular 15 support open until v3 is out of pre-release.

@grosch-intl
Copy link

@EmLauber Any chance of getting faster releases? For an alpha, I was hoping for more like weekly pushes.

@EricBichara
Copy link

Anyone get v3 working with a standalone app? I'm getting issues as soon as i add the MsalInterceptor using:

{ provide: HTTP_INTERCEPTORS, useClass: MsalInterceptor, multi: true, }, provideHttpClient(withInterceptorsFromDi()),

@grosch-intl
Copy link

@EricBichara provideHttpClient doesn't work with this package yet. You need to still add HttpClientModule to the importProvidersFrom call. See issue #5988

@Marcel0024
Copy link

The angular v16 sample still uses the old way .platformBrowserDynamic() in main.ts

@dzhavat
Copy link
Contributor

dzhavat commented Jun 21, 2023

Just updated our app to 3.0.0-beta.0 today and everything still works. We're on Angular v15.

@ShadowNightCoder
Copy link

when will be published the new @azure/msal-angular library update that isn't an alpha that supports angular 15 and 16?

@SirMrJames
Copy link

I think there needs to be a push to get a fully working production release of this. Not supporting Angular 16 is one thing, but Angular 15 was released 8 months ago.

@liam-langstaff
Copy link

+1 for SirMrJames. V16 Bombs out meaning I'll have to remain on (equally an unsupported) v15 due to this.

@devfservant
Copy link

Could you please give us some hindsights of when a stable v3 version will be released?

As already mentioned here, using a beta version is a showstopper for some companies.
It prevents them from upgrading to Angular 15.
On the other hand, Angular 14's security support ends in 4 months: https://endoflife.date/angular.

FYI, we tested MSAL 3.0.0-beta.1 and it works fine.

@jerone
Copy link
Contributor Author

jerone commented Jul 20, 2023

I raised this issue 8 months ago (tomorrow exactly) for Angular 15, almost a month before it's official release.

For a huge company like Microsoft, for a product that screams security, this is a huge let down. 😢

How many of Microsoft products use this library, I'm scared now.

@alexander-kastil
Copy link

@devfservant: I also switched from Angular 15 and MSAL 2.x to Angular 16 and MSAL 3.0.0-beta.1 and it worked with no problem. But I agree with @jerone: Do we want to deploy beta versions to production? Shame on you MSAL Team!!!

@talgershman
Copy link

any news when beta will be over ?

@alexander-kastil
Copy link

@devfservant If you are hosting on azure you could use easy auth instead of msal … supported on static web app, container apps, app services, … it also allows you to get hold of id- and access tokens …

https://learn.microsoft.com/en-us/azure/static-web-apps/authentication-authorization

https://learn.microsoft.com/en-us/azure/container-apps/authentication

@achrysanthakopoulou
Copy link

Version 3.0.0 just released, however I still get the same error when on Angular 16. (Cannot find module '@azure/msal-angular' or its corresponding type declarations.)
Anyone?

@greut
Copy link

greut commented Aug 9, 2023

@achrysanthakopoulou -beta.1 is fine, 3.0.0 however is not, wait a bit.

@jo-arroyo
Copy link
Collaborator

Hi all, there was an issue with our release process, and we are currently working on a fix. Thank you all for your patience.

@jerone
Copy link
Contributor Author

jerone commented Aug 12, 2023

@jo-arroyo Have all issues, regarding support for Angular 15 & 16, officially been resolved?

@EmLauber
Copy link
Contributor

Yes, the releases issues were resolved with the patch v3.0.1. I am closing this issue as support for Angular 15 & 16 is now GA. Please see our migration guide for MSAL.Angular v2 to v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature requests. msal-angular Related to @azure/msal-angular package public-client Issues regarding PublicClientApplications tracked-internally Bugs that are tracked by Msft internally
Projects
None yet
Development

No branches or pull requests