Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular16 sample application #5944

Merged
merged 19 commits into from
Jun 7, 2023
Merged

Angular16 sample application #5944

merged 19 commits into from
Jun 7, 2023

Conversation

jo-arroyo
Copy link
Collaborator

@jo-arroyo jo-arroyo commented Apr 28, 2023

Adds Angular 16 application to v3 samples.

@github-actions github-actions bot added documentation Related to documentation. samples Related to the samples apps for the library. labels Apr 28, 2023
@jo-arroyo jo-arroyo marked this pull request as ready for review April 28, 2023 22:13
@touhidrahman touhidrahman mentioned this pull request May 7, 2023
@ghost
Copy link

ghost commented May 29, 2023

Reminder: The next release is scheduled for next week and this PR appears to be stale :(

If changes have been requested please address feedback.
If this PR is still a work in progress please mark as draft.

@ghost ghost added the Needs: Attention 👋 Awaiting response from the MSAL.js team label May 29, 2023
@ghost ghost removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label May 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #5944 (e8bc98b) into dev (81d34b4) will decrease coverage by 0.47%.
The diff coverage is 88.82%.

Flag Coverage Δ
msal-angular 96.73% <96.63%> (+0.22%) ⬆️
msal-browser 86.11% <86.90%> (-0.36%) ⬇️
msal-common 83.22% <ø> (-1.33%) ⬇️
msal-core ?
msal-node 79.73% <ø> (-3.66%) ⬇️
msal-node-extensions ?
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?
Impacted Files Coverage Δ
lib/msal-browser/src/cache/MemoryStorage.ts 100.00% <ø> (ø)
lib/msal-browser/src/crypto/CryptoOps.ts 93.54% <ø> (+1.88%) ⬆️
lib/msal-browser/src/crypto/GuidGenerator.ts 100.00% <ø> (ø)
lib/msal-browser/src/crypto/ModernBrowserCrypto.ts 100.00% <ø> (+6.66%) ⬆️
lib/msal-browser/src/crypto/PkceGenerator.ts 89.47% <ø> (-5.99%) ⬇️
lib/msal-browser/src/crypto/SignedHttpRequest.ts 92.30% <ø> (-1.81%) ⬇️
lib/msal-browser/src/encode/Base64Decode.ts 93.75% <ø> (-0.99%) ⬇️
lib/msal-browser/src/encode/Base64Encode.ts 95.65% <ø> (-0.78%) ⬇️
lib/msal-browser/src/error/BrowserAuthError.ts 94.33% <ø> (-2.57%) ⬇️
...browser/src/error/BrowserConfigurationAuthError.ts 76.92% <ø> (-8.80%) ⬇️
... and 64 more

... and 163 files with indirect coverage changes

@github-actions github-actions bot added the msal-angular Related to @azure/msal-angular package label Jun 6, 2023
@jo-arroyo jo-arroyo merged commit d2b1c88 into dev Jun 7, 2023
@jo-arroyo jo-arroyo deleted the angular16-sample branch June 7, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. msal-angular Related to @azure/msal-angular package samples Related to the samples apps for the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants