Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate allow_broker, use enable_broker_on_windows #613

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

rayluo
Copy link
Collaborator

@rayluo rayluo commented Oct 27, 2023

This PR deprecates the old ClientApplication.__init__(..., allow_broker=True). Please use PublicClientApplication.__init__(..., enable_broker_on_windows=True) instead.

This change is the first step for us to moving to per-platform opt-in flag.

This PR will also close #510 , because we no longer go with that direction.

@jiasli , @xiangyan99,

  • You do not have to immediately make a dependency on this change, but you are still recommended to expose the per-platform opt-in flag in your code base accordingly
  • Please run your smoke test with this PR, as it will likely become the last change in an upcoming MSAL Python 1.25

@rayluo rayluo merged commit 88c4bf8 into dev Nov 2, 2023
12 checks passed
@rayluo rayluo deleted the broker-new-param branch November 2, 2023 16:40
@rayluo rayluo mentioned this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants