Merge pull request #28 from AzCiS/bugfix-2074697

Fix bug 2074697 - Set-ASSDevice silently terminates when no optional par...
AzureRT · Mar 25, 2015 · d860931 · d860931
2 parents 6acc061 + 7262852
commit d860931
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/...nagement/StorSimple/Commands.StorSimple/Cmdlets/DeviceDetails/SetAzureStorSimpleDevice.cs b/...nagement/StorSimple/Commands.StorSimple/Cmdlets/DeviceDetails/SetAzureStorSimpleDevice.cs
@@ -135,6 +135,16 @@ public override void ExecuteCmdlet()
 
         private bool ProcessParameters()
         {
+            // Make sure that atleast one of the settings has been provided.
+            // Its no use making a request when the user didnt specify any of
+            // the settings.
+            if (string.IsNullOrEmpty(NewName) && TimeZone == null &&
+                string.IsNullOrEmpty(SecondaryDnsServer) &&
+                (StorSimpleNetworkConfig == null || StorSimpleNetworkConfig.Count() < 1))
+            {
+                throw new ArgumentException(Resources.SetAzureStorSimpleDeviceNoSettingsProvided);
+            }
+
             // Make sure that the DeviceId property has the appropriate value irrespective of the parameter set
             if (ParameterSetName == StorSimpleCmdletParameterSet.IdentifyByName)
             {

diff --git a/src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.Designer.cs b/src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.Designer.cs
diff --git a/src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.resx b/src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.resx
@@ -513,4 +513,7 @@
   <data name="CIKInvalidWithException" xml:space="preserve">
     <value>Invalid value for Registration Key. CIK provided couldnt be used to decrypt the secrets! The exact exception while decrypting is "{0}"!</value>
   </data>
+  <data name="SetAzureStorSimpleDeviceNoSettingsProvided" xml:space="preserve">
+    <value>No settings were provided for updating device details.</value>
+  </data>
 </root>