Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BusyStatus belongs with the synApps busy record support. #991

Closed
prjemian opened this issue Jul 1, 2024 · 4 comments · Fixed by #993
Closed

BusyStatus belongs with the synApps busy record support. #991

prjemian opened this issue Jul 1, 2024 · 4 comments · Fixed by #993
Assignees
@prjemian
Labels
maintenance
Milestone
1.6.20

Comments

@prjemian
Copy link
Contributor

prjemian commented Jul 1, 2024

BusyStatus (class) belongs with the synApps busy record support.

Originally posted by @prjemian in #988 (comment)
@prjemian prjemian self-assigned this Jul 1, 2024
@prjemian prjemian added this to the 1.6.20 milestone Jul 1, 2024
@prjemian
Copy link
Contributor Author

prjemian commented Jul 1, 2024 •
edited
Loading

Also, note the addition of planar undulator in the change history. I missed this detail in PR #988.

Instead, added in PR #993.

@prjemian
Copy link
Contributor Author

prjemian commented Jul 1, 2024

Note that BusyStatus was removed in apstools 1.6.0 and is not used in the PlanarUndulator support. Instead of moving it, the BusyStatus class can be removed entirely.

@prjemian
Copy link
Contributor Author

prjemian commented Jul 1, 2024

But wait for the corrections in PR #993 first.

@prjemian prjemian mentioned this issue Jul 1, 2024
Merged
@prjemian
Copy link
Contributor Author

prjemian commented Jul 1, 2024

Will complete with other code fixes in #993.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prjemian prjemian

Labels
maintenance
Projects
No open projects
apstools 1.6.20 project
Status: Done
Milestone
1.6.20
Development

Successfully merging a pull request may close this issue.

various fixes BCDA-APS/apstools
1 participant
@prjemian