Wrote new support for the planar undulator. #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S-U) undulator. The new support uses positioners, so the following sub-devices can be moved directly. - energy - gap - energy_taper - gap_taper
prjemian
reviewed
Jul 1, 2024
|
@canismarko -- Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new support uses positioners, so the following sub-devices can be moved directly.
I removed the ApsDualUndulator class for now because it's not clear how to specify the kind of undulators for each branch, and it would be trivial for beamline's to create this device themselves. I'm not opposed to adding it back if there 's a good solution, though.
I tested this on the downstream ID at 25-ID.