Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to updated PVs and commented out ones which cannot be found #981

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Change to updated PVs and commented out ones which cannot be found #981

merged 1 commit into from
Jul 1, 2024

Conversation

MDecarabas
Copy link
Collaborator

@MDecarabas MDecarabas commented May 29, 2024 •
edited by prjemian
Loading

@MDecarabas MDecarabas requested a review from prjemian May 29, 2024 19:35
@MDecarabas MDecarabas self-assigned this May 29, 2024
prjemian
prjemian reviewed May 29, 2024
View reviewed changes
apstools/devices/aps_machine.py
@@ -88,12 +88,18 @@ class ApsMachineParametersDevice(Device):
# 'Stored Beam',
# 'Delivered Beam',
# 'MAINTENANCE')
shutter_permit = Component(EpicsSignalRO, "ACIS:ShutterPermit", string=True)

# shutter_permit = Component(EpicsSignalRO, "ACIS:ShutterPermit", string=True) # Not Found
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if I can find this PV (or its replacement) on one of the other screens...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A beamline-independent PV is not obvious. Another way is to do a recursive grep through the screen files, such as:

grep -R ShutterPermit . | grep ACIS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./asdops/screens/SRcomfort.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRcomfort.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRcomfort.adl: chan="ACIS:ShutterPermit"
./asdops/screens/checklist.adl: chan="ACIS:ShutterPermit"
./asdops/screens/checklist.adl: chan="ACIS:ShutterPermit"
./asdops/screens/checklist.adl: chan="ACIS:ShutterPermit"
./asdops/screens/checklist.adl: chan="ACIS:ShutterPermit"
./asdops/screens/checklist.adl: chan="ACIS:ShutterPermit"
./asdops/screens/checklist.adl: chan="ACIS:ShutterPermit"
./asdops/screens/checklist.adl: chan="ACIS:ShutterPermit"
./asdops/screens/checklist.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRInj24s.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRInjHybrid.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRcomfort_2015.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRcomfort_2015.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRInj324s.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRInj24s_P0.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRInj324s_P0.adl: chan="ACIS:ShutterPermit"
./asdops/screens/SRInjHybrid_P0.adl: chan="ACIS:ShutterPermit"


Yet, this PV does not respond to `caget`

@prjemian
Copy link
Contributor

I found a screen with shutter permit PVs for each beam line:

image

Here is BEAMLINE PER for 1ID (S01ID-FEEPS:ShutterPermitWarnM):
image

@prjemian
Copy link
Contributor

I'll keep searching for some that applies to all beam lines.

@MDecarabas
Copy link
Collaborator Author

Is the move making the prefix part of the initialization and then having then we can keep just: prefix:ShutterPermitWarnM?

@prjemian
Copy link
Contributor

prjemian commented Jun 3, 2024

The prefix (as you've shown it) is passed in by the user when creating the python object: obj = TheDevice("prefix:", name="obj"). Note the : belongs with the prefix. Internally, Components can then use the part after the prefix:, such as "ShutterPermitWarnM"

prjemian
prjemian approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this as-is.

@prjemian prjemian marked this pull request as ready for review July 1, 2024 19:53
@prjemian prjemian merged commit 08c41fc into main Jul 1, 2024
12 of 13 checks passed
@prjemian prjemian deleted the aps_machine branch July 8, 2024 20:16
@prjemian prjemian added this to the 1.6.20 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prjemian prjemian prjemian approved these changes

Assignees

@MDecarabas MDecarabas

Labels
None yet
Projects
No open projects
apstools 1.6.20 project
Status: Done
Milestone
1.6.20
Development

Successfully merging this pull request may close these issues.

aps_machine.py
2 participants
@MDecarabas @prjemian