Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugins support & debug-tracer plugin #67

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add plugins support & debug-tracer plugin #67

wants to merge 2 commits into from

Conversation

mmamayka
Copy link
Member

Adds

  • DynamicLibrary class that is a simple wrapper class over the linux SO loading interface
  • Plugin class that holds state of the BESM plugin
  • Support of plugin loading by the Machine & HookManager classes
  • Two new events SIMULATION_STARTED & SIMULATION_FINISHED to hook manager

Moves all tracing functional from standalone runner to DebugTracer plugin placed at plugins/debug_tracer

@mmamayka mmamayka added the enhancement New feature or request label Oct 14, 2023
@mmamayka mmamayka self-assigned this Oct 14, 2023
levBagryansky
levBagryansky approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@levBagryansky levBagryansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmamayka Thanks

c71n93
c71n93 requested changes Oct 19, 2023
View reviewed changes
src/CMakeLists.txt
@@ -19,6 +19,9 @@ PUBLIC
besm666_decoder
besm666_sim
)
target_link_options(besm666_shared PRIVATE
"-Wl,-export-dynamic"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ld for macos is using -export_dynamic. Add if for macos, please)

standalone/CMakeLists.txt
capstone::capstone
)
target_link_options(besm666_standalone PRIVATE
"-Wl,-export-dynamic"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ld for macos is using -export_dynamic. Add if for macos, please)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c71n93 c71n93 c71n93 requested changes

@levBagryansky levBagryansky levBagryansky approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@mmamayka mmamayka

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmamayka @levBagryansky @c71n93