Assotiative cache implementation #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmamayka
requested changes
Oct 19, 2023
|
@mmamayka Pls, have a look. |
mmamayka
reviewed
Oct 21, 2023
There was a problem hiding this comment.
Looks really good! But unit tests need to be added. At least one dummy unit test that checks, the Cache class can be properly instantiated, cache entry can be added and found after. Also, I propose to check a cache replacement correctness by adding N elements with same hash to the cache, where N >= Sets, and looking for them.
|
@mmamayka pls, have a look. |
levBagryansky
previously approved these changes
Oct 24, 2023
levBagryansky
approved these changes
Oct 31, 2023
mmamayka
approved these changes
Oct 31, 2023
|
@ivan-egorov42 the puzzle #77 is still not solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests will be added soon. Pls, have a look @mmamayka