Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy org.bukkit.event.player.AsyncPlayerChatEvent #2227

Closed
JanReich opened this issue Sep 8, 2024 · 4 comments
Closed

Legacy org.bukkit.event.player.AsyncPlayerChatEvent #2227

JanReich opened this issue Sep 8, 2024 · 4 comments
Assignees
Labels
✔️ Confirmed Confirmed bugs that can be replicated 🔧 Potential fix A potential fix was already submitted

Comments

@JanReich
Copy link

JanReich commented Sep 8, 2024

Minecraft's Version

This server is running Paper version git-Paper-497 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: d8d54d9 on ver/1.20.4)

Plugin's Version

SuperiorSkyblock2 version 2024.2-b315

Describe the bug

[17:26:42 INFO]: [SignedVelocity] Enabling SignedVelocity v1.2.3
[17:26:42 WARN]: [SignedVelocity] ------------------------------
[17:26:42 WARN]: [SignedVelocity] The following plugins have listener in legacy org.bukkit.event.player.AsyncPlayerChatEvent event: SuperiorSkyblock2, Plan.
[17:26:42 WARN]: [SignedVelocity] This may negatively affect the functionality of SignedVelocity,
[17:26:42 WARN]: [SignedVelocity] please report to the author to use Paper's AsyncChatEvent and/or AsyncChatDecorateEvent.
[17:26:42 WARN]: [SignedVelocity] ------------------------------

To Reproduce

Install SignedVelocity and SSB2

Additional Information

No response

@JanReich JanReich added the Pending Pending reports to be investigated label Sep 8, 2024
@OmerBenGera
Copy link
Member

The event is not deprecated or anything like that:
https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/event/player/AsyncPlayerChatEvent.html

Why does SignedVelocity care about the plugin listening to the event? Have you tried reaching them?
Also, what is that plugin?

@OmerBenGera OmerBenGera added 📝 Missing information Required information is missing and removed Pending Pending reports to be investigated labels Sep 9, 2024
@JanReich
Copy link
Author

JanReich commented Sep 9, 2024

The event is deprecated please look at the paper docs (link below). Signed Velocity is a Paper exklusive plugin and is needed that plugins are allowed to edit and send modified messages to the player. Without this plugin signed chatmessages cannot be changed on velocity networks.

I have used this event in my plugins before too but I changed it to the AsyncChatEvent it works almost the same as the old Event.

https://jd.papermc.io/paper/1.21.1/org/bukkit/event/player/AsyncPlayerChatEvent.html

@OmerBenGera OmerBenGera added ✔️ Confirmed Confirmed bugs that can be replicated and removed 📝 Missing information Required information is missing labels Sep 13, 2024
@OmerBenGera
Copy link
Member

OmerBenGera commented Sep 13, 2024

Check out latest dev build, let me know if everything works as intended

@OmerBenGera OmerBenGera added the 🔧 Potential fix A potential fix was already submitted label Sep 13, 2024
@JanReich
Copy link
Author

It worked thank you for improving it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✔️ Confirmed Confirmed bugs that can be replicated 🔧 Potential fix A potential fix was already submitted
Projects
None yet
Development

No branches or pull requests

2 participants