org.json JPMS Module Naming #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GedMarc
added a commit
to GedMarc/JSON-java
that referenced
this pull request
Nov 26, 2018
Just until BGehrels#3 gets done
|
PR killed off, no changes to the package are being considered at this time. Can download the libraries here that can be used. |
|
@GedMarc @BGehrels , can we reopen this now that stleary#451 is reopened? it looks like these changes should still work and can be tested against different JVM versions |
|
ah, never mind, I see this was replaced by #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attaches a valid module-info.class file into the final packaged jar for deployment,
This keeps compatibility for JDK 1.6, while strictly naming the module.
The outputs are (jar renamed to zip)
json-20180813.zip
json-20180813-javadoc.zip
json-20180813-sources.zip