[Android] Fix WSL compatibility and improvement to script #3503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For unknown reason, it will exit 1 with "cache_dir must be an absolute path without ./ or ../ in it" in WSL. Add double quote to fix it.
1. It is extremely inefficient to delete downloaded files and download them again for every new build 2. Allow resuming partial downloads whenever possible 3. Delete the files when passing --clean
|
Thanks for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description of the Change
Path does not parse correctly for
build_all.shin WSL. Use double quotes.Eliminate the need to redownload the NDK and source code for OpenSSL and cURL for every new build.
Alternate Designs
Virtualbox VM is slower, heavier, bandwidth intensive and time consuming just to set up one. WSL is much lighter and support is improving with the use of Visual Studio Code. Using Windows version of Android Studio should be possible. WSL needs to install the same dependencies listed in Vagrantfile. WSL also needs python2 to deal with
make_standalone_toolchain.py.ATM requires copying of entire repo to a readable path after binary compilation as Android Studio does not allow reading project files over WSL network share. However some files may not be copied properly because of symlink files. Certain case sensitive files (mainly Android toolchain files) will overwrite each other when copied. The app can still be compiled in Android Studio.
Or just map it to a network drive. microsoft/WSL#3854 (comment)
However that causes IOExecptionError at Gradle.
Release Notes
N/A