chore: fix clippy lints

consensus/src/coding.rs

@@ -98,25 +98,27 @@ impl AsRef<[u8]> for ByteStr {
 }
 
 impl From<Vec<u8>> for ByteStr {
-    fn from(value: Vec<u8>) -> Self { Self(Confined::try_from(value).expect("u32 >= usize")) }
+    fn from(value: Vec<u8>) -> Self {
+        Self(Confined::try_from(value).expect("byte string size exceeds 4GB"))
+    }
 }
 
 impl From<TinyBlob> for ByteStr {
-    fn from(vec: TinyBlob) -> Self { ByteStr(Confined::from_collection_unsafe(vec.into_inner())) }
+    fn from(vec: TinyBlob) -> Self { ByteStr(Confined::from_checked(vec.release())) }
 }
 
 impl From<SmallBlob> for ByteStr {
-    fn from(vec: SmallBlob) -> Self { ByteStr(Confined::from_collection_unsafe(vec.into_inner())) }
+    fn from(vec: SmallBlob) -> Self { ByteStr(Confined::from_checked(vec.release())) }
 }
 
 impl From<MediumBlob> for ByteStr {
-    fn from(vec: MediumBlob) -> Self { ByteStr(Confined::from_collection_unsafe(vec.into_inner())) }
+    fn from(vec: MediumBlob) -> Self { ByteStr(Confined::from_checked(vec.release())) }
 }
 
 impl ByteStr {
     pub fn len_var_int(&self) -> VarInt { VarInt(self.len() as u64) }
 
-    pub fn into_vec(self) -> Vec<u8> { self.0.into_inner() }
+    pub fn into_vec(self) -> Vec<u8> { self.0.release() }
 }
 
 #[cfg(feature = "serde")]

consensus/src/script.rs

@@ -306,7 +306,7 @@ impl ScriptBytes {
 
     pub fn len_var_int(&self) -> VarInt { VarInt(self.len() as u64) }
 
-    pub fn into_vec(self) -> Vec<u8> { self.0.into_inner() }
+    pub fn into_vec(self) -> Vec<u8> { self.0.release() }
 
     pub(crate) fn as_var_int_bytes(&self) -> &VarIntBytes { &self.0 }
 }

consensus/src/sigcache.rs

@@ -421,12 +421,12 @@ impl<Prevout: Borrow<TxOut>, Tx: Borrow<Transaction>> SighashCache<Prevout, Tx>
         // Add all necessary inputs...
         let sig_script = script_pubkey.as_script_bytes().clone().into();
         if anyone_can_pay {
-            tx.inputs = confined_vec![TxIn {
+            tx.inputs = VarIntArray::from_checked(vec![TxIn {
                 prev_output: tx_src.inputs[input_index].prev_output,
                 sig_script,
                 sequence: tx_src.inputs[input_index].sequence,
                 witness: none!(),
-            }];
+            }]);
         } else {
             let inputs = tx_src.inputs.iter().enumerate().map(|(n, input)| TxIn {
                 prev_output: input.prev_output,
@@ -444,7 +444,7 @@ impl<Prevout: Borrow<TxOut>, Tx: Borrow<Transaction>> SighashCache<Prevout, Tx>
                 },
                 witness: none!(),
             });
-            tx.inputs = VarIntArray::from_iter_unsafe(inputs);
+            tx.inputs = VarIntArray::from_iter_checked(inputs);
         }
         // ...then all outputs
         tx.outputs = match sighash_flag {
@@ -454,7 +454,7 @@ impl<Prevout: Borrow<TxOut>, Tx: Borrow<Transaction>> SighashCache<Prevout, Tx>
                     .take(input_index + 1)  // sign all outputs up to and including this one, but erase
                     .enumerate()            // all of them except for this one
                     .map(|(n, out)| if n == input_index { out.clone() } else { TxOut::default() });
-                VarIntArray::from_iter_unsafe(outputs)
+                VarIntArray::from_iter_checked(outputs)
             }
             SighashFlag::None => none!(),
         };

consensus/src/taproot.rs

@@ -852,7 +852,7 @@ pub enum AnnexError {
 #[wrapper(Deref, AsSlice, Hex)]
 #[wrapper_mut(DerefMut, AsSliceMut)]
 #[derive(StrictType, StrictDumb, StrictEncode, StrictDecode)]
-#[strict_type(lib = LIB_NAME_BITCOIN, dumb = Self(confined_vec![0x50]))]
+#[strict_type(lib = LIB_NAME_BITCOIN, dumb = { Self(VarIntBytes::with(0x50)) })]
 pub struct Annex(VarIntBytes<1>);
 
 impl TryFrom<Vec<u8>> for Annex {
@@ -877,7 +877,7 @@ impl Annex {
 
     pub fn len_var_int(&self) -> VarInt { VarInt(self.len() as u64) }
 
-    pub fn into_vec(self) -> Vec<u8> { self.0.into_inner() }
+    pub fn into_vec(self) -> Vec<u8> { self.0.release() }
 
     /// Returns the Annex bytes data (including first byte `0x50`).
     pub fn as_slice(&self) -> &[u8] { self.0.as_slice() }

dbc/src/tapret/tapscript.rs

@@ -55,7 +55,7 @@ impl StrictDeserialize for TapretCommitment {}
 
 impl From<[u8; 33]> for TapretCommitment {
     fn from(value: [u8; 33]) -> Self {
-        let buf = Confined::try_from_iter(value).expect("exact size match");
+        let buf = Confined::from_iter_checked(value);
         Self::from_strict_serialized::<33>(buf).expect("exact size match")
     }
 }
@@ -65,7 +65,7 @@ impl TapretCommitment {
     pub fn to_vec(&self) -> Vec<u8> {
         self.to_strict_serialized::<33>()
             .expect("exact size match")
-            .into_inner()
+            .release()
     }
 }