Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to specify downloadable parameters in protocol #324

Open
luissian opened this issue Sep 29, 2024 · 1 comment
Open

Unable to specify downloadable parameters in protocol #324

luissian opened this issue Sep 29, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@luissian
Copy link
Member

luissian commented Sep 29, 2024

Description of the bug

When defined the parameters in a new protocol is not possible to specify the parameters that are downloadable.

The downloadable is defined for sample projects but not here.

Additional to this fact, when modifying the protocol parameters the option of Min and Max are not showed

Command used and terminal output

No response

Relevant files

No response

System information

No response

@luissian luissian added the bug Something isn't working label Sep 29, 2024
@luissian luissian added this to the Ready for 3.2.0 milestone Sep 29, 2024
@luissian luissian self-assigned this Sep 29, 2024
@luissian
Copy link
Member Author

Added the fields for download and including min and max value for protocols.

It was renamed the Search field to Downloadable and to get it consistence parameter value the field has been renamed in models.

When running the installation script it stops to ask if field is renamed. To avoid the hanging waiting for user interaction, that never acts, because no prompt is returned to set the answer, parameter --noinput was added. This acts as answer No, so the old parameter is deleted and the new one is created. This is not any issue because the search option was never used.

luissian added a commit to luissian/iskylims that referenced this issue Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant