v1.81.4 -- Fix issue found by Meryem, where prune channels doesn't work correctly in hmrMotionArtifact.m. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- Fix failure to load full head probe fullhead_56x144_v3.SD or ninjaNIRS2022_2023-09-19-18-26-16.snirf files because SnirfClass.GetAuxDataMatrix gets an error when resampling with Matlab's resample function which does not handle a huge difference between aux sample rate and the data sample rate. To fix added local resample function resamplee.m to avoid this issue. DataTree, v1.17.3 -- Fix failure to load full head probe fullhead_56x144_v3.SD or ninjaNIRS2022_2023-09-19-18-26-16.snirf files because SnirfClass.GetAuxDataMatrix gets an error when resampling with Matlab's resample function which does not handle a huge difference between aux sample rate and the data sample rate. To fix added local resample function resamplee.m to avoid this issue. Utils, v1.8.1 -- Fix in ImageRecon error when setting timerange, such that it is more than or less that tHRF. Fix is to get tHRF when ImageRecon GUI launches and use ceiln and floorn for min and max tHRF to make sure it is not out of range. Added floorn.m and ceiln.m to fix this. -- Fix failure to load full head probe fullhead_56x144_v3.SD or ninjaNIRS2022_2023-09-19-18-26-16.snirf files because SnirfClass.GetAuxDataMatrix gets an error when resampling with Matlab's resample function which does not handle a huge difference between aux sample rate and the data sample rate. To fix added local resample function resamplee.m to avoid this issue.
-- Fix issue found by Meryem, where prune channels doesn't work correctly in hmrMotionArtifact.m because combining mlActAuto and mlActMan isn't done correctly such that manual prunning is erased by auto pruning. Add function mlAct_CombineIndexLists to solve issue. Same issue in hmrR_MotionArtifactByChannel.m and hmrR_MotionCorrectWavelet.m. -- Make hmrR_PruneChannels.m user parameters drange and SNRthresh greater precision FuncRegistry, v1.4.2 -- Fix issue found by Meryem, where prune channels doesn't work correctly in hmrMotionArtifact.m because combining mlActAuto and mlActMan isn't done correctly such manual prunning is erased by auto pruning. Same issue in hmrR_MotionArtifactByChannel.m and hmrR_MotionCorrectWavelet.m. -- Make hmrR_PruneChannels.m user parameters drange and SNRthresh greater precision DataTree, v1.17.4 -- Fix probe not displaying in Homer3 because probe.sourcePos2D and probe.detectorPos2D are all zeros (which signifies empty but is not detected as empty) instead of actually empty. Also try to make units for generated 2D probe same as 3D by calling new method ProbeClass.ScaleProjection2D() -- Fix AuxClass eq function to check for different dataTimeSeries sizes when checking if 2 AuxClass objects are equal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.81.4
-- Fix issue found by Meryem, where prune channels doesn't work correctly in hmrMotionArtifact.m because combining mlActAuto and mlActMan isn't done correctly such that manual prunning is erased by auto pruning. Add function mlAct_CombineIndexLists to solve issue. Same issue in hmrR_MotionArtifactByChannel.m and hmrR_MotionCorrectWavelet.m.
-- Make hmrR_PruneChannels.m user parameters drange and SNRthresh greater precision
FuncRegistry, v1.4.2
-- Fix issue found by Meryem, where prune channels doesn't work correctly in hmrMotionArtifact.m because combining mlActAuto and mlActMan isn't done correctly such manual prunning is erased by auto pruning. Same issue in hmrR_MotionArtifactByChannel.m and hmrR_MotionCorrectWavelet.m.
-- Make hmrR_PruneChannels.m user parameters drange and SNRthresh greater precision
DataTree, v1.17.4
-- Fix probe not displaying in Homer3 because probe.sourcePos2D and probe.detectorPos2D are all zeros (which signifies empty but is not detected as empty) instead of actually empty. Also try to make units for generated 2D probe same as 3D by calling new method ProbeClass.ScaleProjection2D()
-- Fix AuxClass eq function to check for different dataTimeSeries sizes when checking if 2 AuxClass objects are equal