Skip to content

Commit

Permalink
NetSpec: don't require lists to specify single-element repeated fields
Browse files Browse the repository at this point in the history
  • Loading branch information
jeffdonahue committed Sep 3, 2015
1 parent 66823b5 commit c248474
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
10 changes: 8 additions & 2 deletions python/caffe/net_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,14 @@ def to_proto(*tops):
def assign_proto(proto, name, val):
"""Assign a Python object to a protobuf message, based on the Python
type (in recursive fashion). Lists become repeated fields/messages, dicts
become messages, and other types are assigned directly."""

become messages, and other types are assigned directly. For convenience,
repeated fields whose values are not lists are converted to single-element
lists; e.g., `my_repeated_int_field=3` is converted to
`my_repeated_int_field=[3]`."""

is_repeated_field = hasattr(getattr(proto, name), 'extend')
if is_repeated_field and not isinstance(val, list):
val = [val]
if isinstance(val, list):
if isinstance(val[0], dict):
for item in val:
Expand Down
3 changes: 1 addition & 2 deletions python/caffe/test/test_net_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ def anon_lenet(batch_size):

def silent_net():
n = caffe.NetSpec()
n.data, n.data2 = L.DummyData(shape=[dict(dim=[3]), dict(dim=[4, 2])],
ntop=2)
n.data, n.data2 = L.DummyData(shape=dict(dim=3), ntop=2)
n.silence_data = L.Silence(n.data, ntop=0)
n.silence_data2 = L.Silence(n.data2, ntop=0)
return n.to_proto()
Expand Down

0 comments on commit c248474

Please sign in to comment.