restore "red X" build failures in Travis #1051
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and other travis cleanup.
A while ago I moved the Travis build into scripts under
./scripts/travis
, and in doing so I caused build failures (e.g. compilation errors, lint errors) to show up as "gray" rather than "red". I still don't really know why this is, as according to the Travis documentation, any non-zero exit codes returned by a command underscript:
should result in the red build failures. It's also unclear to me why I need the|| return 1
aftertravis_build_and_test.sh
-- it seems redundant -- but without it I see the gray Travis failures, so...