Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore "red X" build failures in Travis #1051

Merged
merged 2 commits into from
Sep 11, 2014

Conversation

jeffdonahue
Copy link
Contributor

...and other travis cleanup.

A while ago I moved the Travis build into scripts under ./scripts/travis, and in doing so I caused build failures (e.g. compilation errors, lint errors) to show up as "gray" rather than "red". I still don't really know why this is, as according to the Travis documentation, any non-zero exit codes returned by a command under script: should result in the red build failures. It's also unclear to me why I need the || return 1 after travis_build_and_test.sh -- it seems redundant -- but without it I see the gray Travis failures, so...

@jeffdonahue jeffdonahue force-pushed the travis-red-errors branch 2 times, most recently from 0c5d062 to f468937 Compare September 8, 2014 10:46
@jeffdonahue
Copy link
Contributor Author

Somehow this breaks the CMake build...

Linking CXX shared library libpycaffe.so
/usr/bin/ld: ../lib/libcaffe.a(common.cpp.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC

not sure what to make of that, I'll look at this later.

@jeffdonahue jeffdonahue force-pushed the travis-red-errors branch 12 times, most recently from 636e8ae to c9f9bdb Compare September 11, 2014 15:06
@jeffdonahue
Copy link
Contributor Author

Turns out that the CMake problem with building pycaffe was, I think, a bug in the CMake build, occurring because it had a hidden dependency on the CXX_FLAGS including -fPIC.

.travis.yml did source scripts/travis/travis_install.sh, which contained export CXX_FLAGS=-fPIC (used for gflags). So when I changed the sourceing of that script to directly call it instead, the environment variable didn't take effect outside the build script. To fix this I added -fPIC to CMAKE_CXX_FLAGS in f036ef4. (The first commit, which breaks the CMake build, nicely demonstrates the restoration of the red X on build failures.)

jeffdonahue added a commit that referenced this pull request Sep 11, 2014
restore "red X" build failures in Travis
@jeffdonahue jeffdonahue merged commit c69b3b4 into BVLC:dev Sep 11, 2014
@jeffdonahue jeffdonahue deleted the travis-red-errors branch September 11, 2014 15:46
mitmul pushed a commit to mitmul/caffe that referenced this pull request Sep 30, 2014
restore "red X" build failures in Travis
RazvanRanca pushed a commit to RazvanRanca/caffe that referenced this pull request Nov 4, 2014
restore "red X" build failures in Travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant