Add ppa for gflag and glog #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are multiple lines of |
|
Probably a little bit. But this will need to duplicate the if on cmake. One for adding repository and one for the cmake installation. |
|
@jeffdonahue What do u think? Can be merged? |
| @@ -6,6 +6,7 @@ set -e | |||
| MAKE="make --jobs=$NUM_THREADS" | |||
|
|
|||
| # Install apt packages where the Ubuntu 12.04 default works for Caffe | |||
There was a problem hiding this comment.
please change this comment accordingly since these aren't the Ubuntu 12.04 default, and also add a comment above the add-apt-repository saying # for gflags and glog or something to that effect
|
Thanks @bhack, see my above comment and then I can merge this. |
|
@jeffdonahue Done |
jeffdonahue
added a commit
that referenced
this pull request
Sep 14, 2014
Add ppa for gflag and glog
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Add ppa for gflag and glog
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
Add ppa for gflag and glog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speedup travis build