[Bugfix] Move file reading error checking closer to actual file read command #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if (height > 0 && width > 0) was true, the cv::resize() function would be called before cv_img_origin was confirmed valid; if the image file/filename was not valid, this caused an opencv assert error like this: terminate called after throwing an instance of 'cv::Exception' what(): /tmp/A3p0_4200_32550/batserve/A3p0/glnxa64/OpenCV/modules/imgproc/src/imgwarp.cpp:1725: error: (-215) ssize.area() > 0 in function resize
|
Thanks for the more humane error logic! |
shelhamer
added a commit
that referenced
this pull request
Sep 16, 2014
[fix] Move file reading error checking closer to actual file read command
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
[fix] Move file reading error checking closer to actual file read command
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
[fix] Move file reading error checking closer to actual file read command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if (height > 0 && width > 0) was true, the
cv::resize() function would be called before cv_img_origin was
confirmed valid; if the image file/filename was not valid, this
caused an opencv assert error like this:
terminate called after throwing an instance of 'cv::Exception'
what(): /tmp/A3p0_4200_32550/batserve/A3p0/glnxa64/OpenCV/modules/imgproc/src/imgwarp.cpp:1725: error: (-215)
ssize.area() > 0 in function resize