Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bp::object instead of PyObject* for self in Python layer #2456

Merged
merged 1 commit into from
May 14, 2015

Conversation

longjon
Copy link
Contributor

@longjon longjon commented May 14, 2015

From @tnarihi in #2001. Rather than couple it to the other changes in that PR, I've extracted this little cleanup for immediate review and merge.

@tnarihi, I've used your author information here; let me know if there are any issues with that.

This simply allows direct use of the nicer bp::object interface.
@jeffdonahue
Copy link
Contributor

LGTM. Thanks @tnarihi and thanks for breaking off this piece @longjon.

jeffdonahue added a commit that referenced this pull request May 14, 2015
Use bp::object instead of PyObject* for self in Python layer
@jeffdonahue jeffdonahue merged commit d1abf9d into BVLC:master May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants