Change log levels in upgrade_proto #2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? I haven't run into any other problems like this, so it seems that most of the Caffe log message levels are reasonable. Can we set this one section right? Note that an error message still occurs if the upgrade fails. |
| @@ -588,7 +588,7 @@ bool UpgradeNetAsNeeded(const string& param_file, NetParameter* param) { | |||
| if (NetNeedsV0ToV1Upgrade(*param)) { | |||
| // NetParameter was specified using the old style (V0LayerParameter); try to | |||
| // upgrade it. | |||
| LOG(ERROR) << "Attempting to upgrade input file specified using deprecated " | |||
| LOG(INFO) << "Attempting to upgrade input file specified using deprecated " | |||
| << "V0LayerParameter: " << param_file; | |||
There was a problem hiding this comment.
please adjust alignment here and at 609+614
|
see alignment nitpick, otherwise LGTM |
It's not an error if the upgrade succeeds
lukeyeager
force-pushed
the
fix-log-levels
branch
from
31c7ec6
to
63e45b7
Compare
|
No problem. Fixed alignment and rebased to master. |
jeffdonahue
added a commit
that referenced
this pull request
Aug 3, 2015
Change log levels in upgrade_proto
|
Thanks @lukeyeager! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion here: NVIDIA/DIGITS#140
If you finetune on an out-of-date model and the upgrade is successful, then there shouldn't be any
ERRORmessages in the logs.