Fix MultiGPU Testing #2931
Merged
Fix MultiGPU Testing #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronghanghu
force-pushed
the
fix-gpu-test
branch
2 times, most recently
from
1cb3c44
to
e34c5ae
Compare
|
@thatguymike This should fix the original issue in #2926, although not for the case in #2926 (comment) |
This is a patch for multi-gpu testing issue (BVLC#2926). The problem fixed in this commit is that when calling make runtest with TEST_GPUID != 0 on a MultiGPU machine, solver tests will crash because gpu ids in multi-gpu tests doesn't match that of single GPU test.
ronghanghu
force-pushed
the
fix-gpu-test
branch
from
e34c5ae
to
3778a2a
Compare
|
Setting CUDA_VISIBLE_DEVICES may be a better idea, but I didn't figure out how to set it up automatically, to ensure Multi-GPU is tested by default on multi-gpu machines, while avoiding the crash in #2926 (comment) |
ronghanghu
added a commit
that referenced
this pull request
Aug 15, 2015
Fix MultiGPU solver test crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch for multi-gpu testing issue (#2926). The problem is when calling
make runtestwith TEST_GPUID != 0 on a MultiGPU machine, solver tests will crash because gpu ids in multi-gpu tests doesn't match that of single GPU test.Note: this still doesn't fix the crash if you have 2 widely different device at the same time. #2926 (comment)