Android AAR project #1440
Open
Android AAR project #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedricGuillemet
requested review from
bghgary,
ryantrem,
docEdub and
SergioRZMasson
ryantrem
reviewed
Oct 10, 2024
Co-authored-by: Ryan Tremblay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having the Android Playground app, split in an shared BabylonNative AAR library and a smaller app.
This change consists in adding a new Module project to the playground. Moving code into that new module: JNI layer, Java view and Wrapper, cmake to make the jni.so. Java namespace renamed to make it easier to integrate. And finally, add a dependency to the .aa in the app.
Min Android SDK version bumped to v25.
Running Android Playground App is the same: open with Android Studio then run app on device.
Produced .aar can be shared (like a npm, nuget, or local file ...) and integration will be way simpler: no need to clone BN, modify app gradle with cmake, add .cpp, etc...
Integration/doc will be part of another PR.
fixes #1435
cc @okwasniewski