Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BIP-729] Enable WBTC/pumpBTC Gauge [Ethereum] #1480

Merged
merged 7 commits into from
Nov 1, 2024
Merged

[BIP-729] Enable WBTC/pumpBTC Gauge [Ethereum] #1480

merged 7 commits into from
Nov 1, 2024

Conversation

Xeonus
Copy link
Collaborator

@Xeonus Xeonus commented Oct 30, 2024 •
edited
Loading

  • enable pumpBTC:wBTC gauge on Ethereum
  • no rate provider needed, pumpBTC 1:1 backed with wBTC
  • Proposal

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

FILENAME: BIPs/2024-W45/BIP-729.json
COMMIT: 7e3739631572ab1b51902f0e87ad7ad3ec5cebed

Validator Result
validate_contains_msig ✅
validate_msig_in_address_book ✅
validate_chain_specified ✅
validate_file_has_bip ✅
validate_path_has_weekly_dir ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

FILENAME: BIPs/2024-W45/BIP-729.json
MULTISIG: multisigs/lm (mainnet:0xc38c5f97B34E175FFd35407fc91a937300E33860)
COMMIT: 7e3739631572ab1b51902f0e87ad7ad3ec5cebed
CHAIN(S): mainnet
TENDERLY: 🟩 SUCCESS

Gauge Validator Result
validate_preferential_gauge ✅
validate_rate_providers_safety -- 
+-----------------------+---------------------------------------------------------------------+-----------------+--------------------------------------------------+----------------------------------------------------------+--------------------------------------------+----------------+---------+----------+
| function              | pool_id_and_address                                                 | symbol_and_info | gauge_address_and_info                           | tokens                                                   | rate_providers                             | review_summary |   bip   | tx_index |
+-----------------------+---------------------------------------------------------------------+-----------------+--------------------------------------------------+----------------------------------------------------------+--------------------------------------------+----------------+---------+----------+
| GaugeAdderV4/addGauge | 0x2238ab6c8c58473a5e81b86ec352322fb3f5edd80000000000000000000006de  | pumpBTC/wBTC    | root: 0xDFaD195F91e1591ae8Eb4c1c7183185CeF58864D | 0x2238aB6c8c58473a5e81b86ec352322fB3f5Edd8: pumpBTC/wBTC | 0x0000000000000000000000000000000000000000 |       --       | BIP-729 |    0     |
|                       | pool_address: 0x2238aB6c8c58473a5e81b86ec352322fB3f5Edd8            | fee: 0.02       | side: None                                       | 0x2260FAC5E5542a773Aa44fBCfeDf7C193bc2C599: WBTC         | 0x0000000000000000000000000000000000000000 |       --       |         |          |
|                       |                                                                     | a-factor: 500   | style: mainnet                                   | 0xF469fBD2abcd6B9de8E169d128226C0Fc90a012e: pumpBTC      | 0x0000000000000000000000000000000000000000 |       --       |         |          |
|                       |                                                                     |                 | cap: 100.0%                                      |                                                          |                                            |                |         |          |
|                       |                                                                     |                 | preferential: True                               |                                                          |                                            |                |         |          |
+-----------------------+---------------------------------------------------------------------+-----------------+--------------------------------------------------+----------------------------------------------------------+--------------------------------------------+----------------+---------+----------+

gosuto-inzasheru
gosuto-inzasheru requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pool does not match the pool in the proposal (https://balancer.fi/pools/ethereum/v2/0x2238ab6c8c58473a5e81b86ec352322fb3f5edd80000000000000000000006de)

@gosuto-inzasheru
Copy link
Member

looks like a mistake on their side, gauge address mentioned is wrong. i replied in the forum

@Zen-Maxi
Correct-Gauge
bb67e90 
Correcting gauge for Ethereum mainnet pumpBTC pool. Mix up between their base and Mainnet pool.
@Zen-Maxi Zen-Maxi merged commit a441486 into BalancerMaxis:main Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosuto-inzasheru gosuto-inzasheru gosuto-inzasheru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xeonus @gosuto-inzasheru @Zen-Maxi