Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ExoPlayer to 2.19.1 (Xamarin branch) #165

Merged
merged 8 commits into from
Aug 29, 2023

Conversation

ArchangelWTF
Copy link
Contributor

@ArchangelWTF ArchangelWTF commented Aug 29, 2023

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Updates the Xamarin branch to 2.19.1

This also heavily breaks ExoPlayer.Effect, but I'm not even sure if that's largely used in XF anyway.

@martijn00 Not sure if you saw my previous comment on the other PR as you had asked me to look into the dependabot PR's, if you could set me as a collaborator of this repository so that I can re-run and merge if needed that'd be great!

⤵️ What is the current behavior?

🆕 What is the new behavior (if this is a feature change)?

💥 Does this PR introduce a breaking change?

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines
  • Relevant documentation was updated
  • Rebased onto current develop

@martijn00 martijn00 merged commit 2989409 into Baseflow:xamarin Aug 29, 2023
1 check passed
@martijn00
Copy link
Member

@ArchangelWTF i've given you Triage access, can you see if that works for you? I'm happy to keep merging and maintaining stuff with your help.

@martijn00
Copy link
Member

@ArchangelWTF and please look carefully when updating dependencies if they match the Exoplayer versions used here: https://github.com/google/ExoPlayer/blob/release-v2/constants.gradle#L46

@ArchangelWTF
Copy link
Contributor Author

ArchangelWTF commented Aug 30, 2023

@ArchangelWTF i've given you Triage access, can you see if that works for you? I'm happy to keep merging and maintaining stuff with your help.

@martijn00 I think I may need write permissions to approve GitHub PR's and to re-run CI/CD through GitHub actions, I can close them but that's not much help.

I definitively intend even with write to still have you approve and merge my PR's at least to make sure I've got a final go-ahead (For production branches at least) and I think write will be handy to have regardless due to me being able to move the work I've done already on Media3 here instead of on my fork.

@ArchangelWTF
Copy link
Contributor Author

@martijn00 Did you have a chance to look at the comment I've written above yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants