[LocationPermission] Fix warning UI unresponsive in mainthread when c… #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alling locationServicesEnabled
mvanbeusekom
requested changes
May 31, 2024
There was a problem hiding this comment.
Hi @honghai2196,
The change looks good, however could you please also update the CHANGELOG.md and pubspec.yaml as requesting in the PR template?
…read when checking location state
I have pushed changes follow your comment. Please re-review. Thanks |
mvanbeusekom
requested changes
May 31, 2024
|
@mvanbeusekom please re-review it. thanks |
|
@honghai2196 thank you very much for this contribution. I have just published these changes to pub.dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alling locationServicesEnabled
Fix Xcode warning when checking Location Services Enabled/Disabled
This PR fix this issue: 1002
Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.mdto add a description of the change.///).main.dart format .and committed any changes.flutter analyzeand fixed any errors.