Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle limit and session in .count() method #1040

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Handle limit and session in .count() method #1040

merged 5 commits into from
Oct 8, 2024

Conversation

CAPITAINMARVEL
Copy link
Contributor

@CAPITAINMARVEL CAPITAINMARVEL commented Oct 7, 2024 •
edited by adeelsohailahmed
Loading

@CAPITAINMARVEL CAPITAINMARVEL requested a review from a team October 7, 2024 13:06
@CAPITAINMARVEL CAPITAINMARVEL added the bug Something isn't working label Oct 7, 2024
@CAPITAINMARVEL
Copy link
Contributor Author

Thought ?

LawMixer
LawMixer approved these changes Oct 7, 2024
View reviewed changes
Copy link

@LawMixer LawMixer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple pr, looks good!

@CAPITAINMARVEL CAPITAINMARVEL changed the title fix count issue Handle limit and session in count Oct 7, 2024
@adeelsohailahmed adeelsohailahmed changed the title Handle limit and session in count Handle limit and session in .count() method Oct 7, 2024
adeelsohailahmed
adeelsohailahmed approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@adeelsohailahmed adeelsohailahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CAPITAINMARVEL CAPITAINMARVEL enabled auto-merge (squash) October 8, 2024 01:55
@CAPITAINMARVEL CAPITAINMARVEL merged commit 1a897a8 into BeanieODM:main Oct 8, 2024
56 checks passed
@07pepa
Copy link
Member

07pepa commented Oct 8, 2024

this is marvelous work... pun intended

@CAPITAINMARVEL
Copy link
Contributor Author

Close #1010
Close #848

@CAPITAINMARVEL CAPITAINMARVEL deleted the fix_count_issue branch October 8, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@07pepa 07pepa 07pepa approved these changes

@adeelsohailahmed adeelsohailahmed adeelsohailahmed approved these changes

@LawMixer LawMixer LawMixer approved these changes

@staticxterm staticxterm Awaiting requested review from staticxterm

@Riverfount Riverfount Awaiting requested review from Riverfount

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] FindMany count ignores limit set [BUG] FindQuery count() function does not use session parameter
4 participants
@CAPITAINMARVEL @07pepa @adeelsohailahmed @LawMixer