Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use nuqs package instead of custom code for storing state in url #436

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

ivan-dalmet
Copy link
Member

@ivan-dalmet ivan-dalmet commented Jan 5, 2024

Describe your changes

Use the nuqs package and remove the custom useSearchParamsUpdater hook

Documentation

Docs PR: BearStudio/start-ui-web-docs#48

Checklist

  • I performed a self review of my code
  • I ensured that everything is written in English
  • I tested the feature or fix on my local environment
  • I ran the pnpm storybook command and everything is working
  • If applicable, I created a PR or an issue on the documentation repository

@ivan-dalmet ivan-dalmet self-assigned this Jan 5, 2024
Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
start-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 3:42pm

Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yoannfleurydev yoannfleurydev merged commit 4ce8442 into master Jan 12, 2024
7 checks passed
@yoannfleurydev yoannfleurydev deleted the feat/use-nuqs branch January 12, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants