Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #263: No module named 'pkg_resources' #271

Merged

Conversation

jandom
Copy link
Collaborator

@jandom jandom commented Nov 11, 2023

Just adding setuptools as a dep – will happily refactor in another PR to use importlib?

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #271 (08c0496) into main (50591ba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   69.20%   69.20%           
=======================================
  Files          22       22           
  Lines        3949     3949           
  Branches      715      715           
=======================================
  Hits         2733     2733           
  Misses       1036     1036           
  Partials      180      180           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

setup.py Outdated Show resolved Hide resolved
@orbeckst orbeckst linked an issue Nov 12, 2023 that may be closed by this pull request
orbeckst and others added 3 commits November 12, 2023 14:00
- add py 3.12 to test matrix
- add setuptools to all requirement files
- updated docs: README and sphinx docs
- updated CHANGES
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix & thank you for @njzjz for the input! (I added @njzjz to AUTHORS/CHANGES).

I also added CI for py 3.12 so that we can now officially claim to support py 3.12.

@orbeckst orbeckst merged commit 10516d0 into Becksteinlab:main Nov 12, 2023
17 checks passed
@jandom jandom deleted the jandom/fix/263-no-module-named-pkg-resources branch November 13, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12: No module named 'pkg_resources'
3 participants