feat(symfony5): support Symfony5 and restore travis ci #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
>php7.0
but our bundle contains code only compatible with>php7.1
(nullable typing)... so we already dropped support for php7.0 💃LegacyEventProxy
which is a Symfony@internal
class... and has been brutally removed in Symfony 5How?
(we didn't test it in a real symfony5 project yet... but at least our tests passes 🤷♂)(see REAL TESTING section)EventDispatcherInterface::dispatch
param ordersTreeBuilder::getRootNode()
function which came with4.2
... but since4.2
is not a supported version, we support only4.3
)=> of course this will be a major update ->
v3.0.0
REAL TESTING
I made a simple project to make sure the project does not throw any exception nor deprecation using Symfony5 => https://github.com/Oliboy50/sf5-testing