[PORT] Flavor Roleplaying Overhaul #2274
Conversation
I'm using a MySQL version but this is how it looks on my local branch.
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Don't let the door hit you on the way out |
There was a problem hiding this comment.
DB changes ahead..
@Bokkiewokkie any idea how we handle those? back in my day there was no db!
I know you have to load the new database schema before you run the testmerge, but I'm not sure how that's done without disrupting the current contents of the database |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Fuck it I'll fix you later |
Yeah it's very easy dw |
That's all the review stuff done!
About The Pull Request
Expands on what was ported in this PR:
By porting the Following PRs from Skyrat-TG:
Also random PR from TG which was needed for this thing:
ALSO
Introduces a new character setup tab to contain all the relevant roleplaying stuff in it, what this means is that I have moved the Flavor Text to this new place, and placed everything else that was introduced in this PR (examine panel not included) in that preference tab.
Picture of New Tab
Why It's Good For The Game
Testing Photographs and Procedure
Screenshots&Videos
2023-01-13.19-36-21.mp4
Changelog
🆑Azarak, NotRanged, FlamingLily, nikothedude, Trigg, Iamgoofball, Gandalf2k15, GoldenAlpharex
add: Added flavor text functionality for silicons.
fix: General, Medical, and Security records work again.
add: Security HUDs and medical HUDs can now view sec/medical records on examine, respectively, and can also view general records.
add: Re-implemented silicon flavor texts!
code: Vastly improved the code of the Examine menu's Character Preview, making it a lot more reflective of what the character currently looks like, while also making it much more performant at the same time!
fix: Cyborgs will now appear in the Character Preview (without their lights, sadly) of the Examine panel too!
fix: The examine panel's character preview no longer shows you instead of the person you're looking at.
fix: The Examine Panel should now properly render characters, rather than just a select few mutant bodyparts.
fix: The Examine Panel's preview will now render characters always standing upright, and at 100% size, for consistency.
refactor: Flavor Examine thingy has been replaced with the Examine Panel and all code related to the previous one has been either removed outright or trimmed down.
/:cl: