Relayed BSA is more 'fun' and also random fixes. #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the perfect combination
Bokkiewokkie
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
While the (true) BSA has a lot of oomph on the overmap itself, its actual effects when relayed are somewhat less interesting as it's effectively just a hitscan-penning NAC that leaves no trace once it passed. This gives it a large explosion and some rather unpleasant effects on direct hits instead.
I considered letting it actually truncate ships & spacing a line, but given we do have pvp content on the overmap sometimes (or if some bus contains a foe with a BSA), that'd be a bit rude . Also is similar to the effects when someone fires the thing with the shutters closed.
Also fixes a lot of random things that runtime since I test with pause on runtime enabled and also look at logs sometimes. Sidetracking my beloved.
Why It's Good For The Game
Explosions are nice.
Also fix man good.
Testing Photographs and Procedure
No.
Changelog
🆑
balance: The BSA now goes kaboom when relayed instead of being essentially a ghost NAC shell.
fix: The Eclipse no longer spawns a borg module that should never exist outside of mobs.
fix: DNA no longer has some super weird code for flavor text, instead copying the one of the source mob.
tweak: You can no longer stack interactions on walls. This is to prevent a runtime from actions that modify the type of them (deconstruction mainly).
fix: Paper no longer runtimes if you do not have a pen in hand (???).
fix: Traders no longer do some cursed things to create their trade items, instead using the all-powerful initial().
fix: The stormdrive no longer runtimes if it has zero gas in it.
fix: Some squad assignment stuff shouldn't try to use a list as datum anymore.
/:cl: