PHP 8.4 | FeatureNode: fix implicitly nullable parameter #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to 258 PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameters with a `null` default value, which are not explicitly declared as nullable. This commit fixes the last instance of that in the codebase. Also note that this was effectively an "optional parameter before a required one", so the default value of `null` needs to be removed as well. Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #258
PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameters with a
nulldefault value, which are not explicitly declared as nullable.This commit fixes the last instance of that in the codebase.
Also note that this was effectively an "optional parameter before a required one", so the default value of
nullneeds to be removed as well.Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
@heiglandreas Would you like to look over ? (seeing that you pulled the prior PR)