Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion of in() and notIn() to native enums when called with non-arrays #359

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Aug 21, 2024

  • Added or updated tests
  • Added or updated the README.md
  • Detailed changes in the CHANGELOG.md unreleased section

Related Issue/Intent

image

Changes

Converts the values given to in() or notIn() using iterator_to_array() if they are not surely an array before passing them into in_array().

Breaking changes

None.

@spawnia spawnia added the bug label Aug 21, 2024
@spawnia spawnia force-pushed the fix-in-not-in-with-iterables branch from 9445db9 to facd826 Compare August 21, 2024 10:47
@spawnia spawnia merged commit 934aed9 into master Aug 21, 2024
6 checks passed
@spawnia spawnia deleted the fix-in-not-in-with-iterables branch August 21, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant