Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirrorfs: corrected offset processing #18

Closed
wants to merge 2 commits into from
Closed

Mirrorfs: corrected offset processing #18

wants to merge 2 commits into from

Conversation

don-Pardon
Copy link

Corrected offset processing in MirrorReadFile and MirrorWriteFile.

@BenjaminKim
Copy link
Owner

@don-Pardon Thanks for finding this.
But your and origin code both are wrong.
SetFilePointer function is completely designed badly.
You should better use SetFilePointerEx function.

@don-Pardon
Copy link
Author

@BenjaminKim Thanks for the article, I didn't know that.
I'll fix that later today.

@don-Pardon
Copy link
Author

@BenjaminKim I replaced SetFilePointer with SetFilePointerEx

BenjaminKim pushed a commit that referenced this pull request Jan 2, 2015
@BenjaminKim
Copy link
Owner

@don-Pardon I fixed the code, and seems working well with big files now.

@BenjaminKim BenjaminKim closed this Jan 2, 2015
Maxhy pushed a commit to dokan-dev/dokany that referenced this pull request Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants