Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "live shell" hint reappearing when frame changed #491

Merged

Conversation

RobinDaugherty
Copy link
Member

Fixes the work just merged in #490. The hint was reappearing when the user clicked a different frame.

This logic didn't belong inside of the REPL prototype anyway, so moving it out of there. Using CSS to hide it, we only need to add a body class at startup, or later, but only once.

@coveralls
Copy link

coveralls commented Nov 4, 2020

Pull Request Test Coverage Report for Build 346467872

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.838%

Totals Coverage Status
Change from base Build 346436937: 0.0%
Covered Lines: 490
Relevant Lines: 506

💛 - Coveralls

@BetterErrors BetterErrors deleted a comment from coveralls Nov 4, 2020
@RobinDaugherty RobinDaugherty merged commit afc1e3e into master Nov 4, 2020
@RobinDaugherty RobinDaugherty deleted the fix/hiding-hint-not-working-when-frame-changes branch November 4, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants