[improve][client] PIP-229: Add a common interface to get fields of the MessageIdData #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
force-pushed
the
bewaremypower/pip-229-msg-id-adv
branch
from
3ac0ce6
to
f9d7ad6
Compare
BewareMyPower
changed the title
BewareMyPower
force-pushed
the
bewaremypower/pip-229-msg-id-adv
branch
4 times, most recently
from
bf14ea8
to
34fa858
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
=========================================
Coverage ? 63.46%
Complexity ? 25850
=========================================
Files ? 1822
Lines ? 133142
Branches ? 14673
=========================================
Hits ? 84497
Misses ? 40892
Partials ? 7753
Flags with carried forward coverage won't be shown. Click here to find out more. |
BewareMyPower
force-pushed
the
bewaremypower/pip-229-msg-id-adv
branch
from
bb7e64e
to
fdd32c0
Compare
BewareMyPower
force-pushed
the
bewaremypower/pip-229-msg-id-adv
branch
2 times, most recently
from
f02339d
to
6d1f61b
Compare
BewareMyPower
force-pushed
the
bewaremypower/pip-229-msg-id-adv
branch
2 times, most recently
from
2270912
to
6863357
Compare
BewareMyPower
force-pushed
the
bewaremypower/pip-229-msg-id-adv
branch
from
6863357
to
476e7e8
Compare
…ssageIdData Master issue: apache#18950 ### Motivation We need a common interface to get fields of the MessageIdData. After that, we won't need to assert a MessageId implementation is an instance of a specific class. And we can pass our customized MessageId implementation to APIs like `acknowledge` and `seek`. ### Modifications - Add `MessageIdAdv` to get fields of `MessageIdData`, make all MessageId implementations inherit it (except `MultiMessageIdImpl`). - Add `MessageIdAdvUtils` for the most common used methods. - Replace `BatchMessageAcker` with the `BitSet` for ACK. - Remove `TopicMessageIdImpl#getInnerMessageId` since a `TopicMessageIdImpl` can be treated as its underlying `MessageId` implementation now. - Remove `instanceof BatchMessageIdImpl` checks in `pulsar-client` module by casting to `MessageIdAdv`. After this refactoring, the 3rd party library will no longer need to cast a `MessageId` to a specific implementation. It only needs to cast `MessageId` to `MessageIdAdv`. Users can also implement their own util class so the methods of `MessageIdAdvUtils` are all not public. ### Verifications Add `CustomMessageIdTest` to verify a simple MessageIdAdv implementation that only has the (ledger id, entry id, batch idx, batch size) fields also works for seek and acknowledgment.
BewareMyPower
force-pushed
the
bewaremypower/pip-229-msg-id-adv
branch
from
476e7e8
to
64185ac
Compare
|
The pr had no activity for 30 days, mark with Stale label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
BatchMessageAcker.