fix(modbus-client): respect parallelUnitIdsAllowed in queue #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biancode
merged commit b6145e9
into
BiancoRoyal:feature/pr_respect-_parallel
7 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issues are addressed by this Pull Request?
#472
What does this Pull Request change?
Uses the same technique that is used on serial connections to make sure that modbus requests go out in serial order and not parallel for modbus-tcp connections when
parallelUnitIdsAllowedis disabled.Does this Pull Request introduce any potentially breaking changes?
I don't think so