Minor changes. #411
Minor changes. #411
Conversation
Adding backticks on each side of %s on line 192 made it compatible with MySQL 8.0.15. Haven't tested earlier versions, but it should work. This error prevented b3 from launching: "ERROR 'Query failed [SELECT * FROM groups WHERE `keyword` = "superadmin" LIMIT 1] None: (1064, u\'You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near \\\'groups WHERE `keyword` = "superadmin" LIMIT 1\\\' at line 1\')'".
The B3 only downloaded the log upon connection, and afterwards it doesn't update the log. This fixes it.
Update __init__.py
Removed login information that was printed in the b3.log file, it included password.
MySQL 8.0.15 Compatibility Update
| @@ -326,7 +326,7 @@ def __init__(self, conf, options): | |||
| game_log = self.config.get('server', 'game_log') | |||
| if game_log[0:6] == 'ftp://' or game_log[0:7] == 'sftp://' or game_log[0:7] == 'http://': | |||
| self.remoteLog = True | |||
| self.bot('Working in remote-log mode: %s', game_log) | |||
| self.bot('Working in remote-log mode') | |||
There was a problem hiding this comment.
What is the purpose of this change? Why hiding the gamelog path from the B3 log?
There was a problem hiding this comment.
Because it shows the SFTP/FTP password within the log path.
|
And I didn't make this parser, someone else did. |
|
Do you've a better idea of "fixing it" so it doesn't establish duplicate connections? |
|
Do you've a better idea of "fixing it" so it doesn't establish duplicate connections? Surely there is but I have no time to investigate this and I do not have the correct setup anymore to perform the necessary tests. And I didn't make this parser, someone else did. Ok, I get it, still it will need some cleanup before merging (and possibly testing as I do not have Cod4x) |
|
I'd not say that this "fix" works completely because bot crashes once you give it an order to give a penality so I've to find another way around to fix it. |
Fixed the SFTP plugin which didn't update the log.
Removed the remote-log mode password from the B3.log