Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use the new #classicwebcam_container #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MikeRatcliffe
Copy link

@MikeRatcliffe MikeRatcliffe commented May 29, 2023

Since OctoPrint/OctoPrint#4628 we need to use #classicwebcam_container otherwise all controls and text information provided by this plugin is display:none.

Fixes #38 (Landed in OctoPrint v1.9.0)

Since OctoPrint/OctoPrint#4628 we need to use `#classicwebcam_container` otherwise all controls and text information provided by this plugin is `display:none`.
@SK-StYleZ
Copy link

thank you for the fix, mike!
can someone please review & merge this pr?
thanks! <3

@dpslwk
Copy link

dpslwk commented Sep 28, 2023

@BillyBlaze can you merge?

@lordofbikes lordofbikes mentioned this pull request Feb 17, 2024
@lordofbikes
Copy link

I recently upgraded my OctoPrint instance and had this issue too.
After applying this patch to my instance text information is back and working again.

I opened #41 to see if there is any response.

If not, @MikeRatcliffe can you imagine to adopt the plugin and give it a new home?
Otherwise I can do so, to get this useful plugin back working for other users too.

@MikeRatcliffe
Copy link
Author

MikeRatcliffe commented Feb 19, 2024

I recently upgraded my OctoPrint instance and had this issue too. After applying this patch to my instance text information is back and working again.

I opened #41 to see if there is any response.

If not, @MikeRatcliffe can you imagine to adopt the plugin and give it a new home? Otherwise I can do so, to get this useful plugin back working for other users too.

@lordofbikes I would imaging that you are busy enough with LibreCAD, so I am happy to take over as maintainer for this plugin.

Note to self: if @BillyBlaze doesn't respond to #41 by 4 Mar 2024 then I will need to follow https://github.com/OctoPrint/plugins.octoprint.org/pull/651/files in order to add myself as the new maintainer.

In the meantime, I will update the code in my repo to use more modern methods.

@Drzet
Copy link

Drzet commented Jul 7, 2024

Thank you, it's working !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All controls and text information provided by this plugin is display:none
6 participants