Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After recent update, screen size not right #384

Closed
3DEnthusiast opened this issue Mar 21, 2020 · 16 comments
Closed

After recent update, screen size not right #384

3DEnthusiast opened this issue Mar 21, 2020 · 16 comments

Comments

@3DEnthusiast
Copy link

After the most recent update, when I cancel a print I can not see the confirm button at the bottom. TouchUI will not allow me to scroll up or down to see it.

@dchauran
Copy link

Same issue here, I have to switch to full screen to see it.

@3DEnthusiast
Copy link
Author

3DEnthusiast commented Mar 25, 2020

I have actually figure out that if you scroll the page down before clicking cancel, you can see the submit button. It's a little bit of a pain but works.

@emilecantin
Copy link

I'd bump this up to CRITICAL: I had to cancel a print a few minutes ago, and I couldn't click on the confirm button! I had to run to my desktop computer on the other side of the house to cancel properly.

@bushibot
Copy link

if you rotate a IOS device horizontal then you can see the yes cancel but yeah this messed up currently. The cancel screen floating box over fills the vertical screen.

@timhere
Copy link

timhere commented Apr 5, 2020

Same issue here, I can't find a way to confirm prompts.

@CodeBrauer
Copy link

Maybe there is a way to replace the built-in prompts with native prompt()? This would be much easier and more accessible for any device?

@bushibot
Copy link

bushibot commented Apr 6, 2020

It's dumb, but if I unlock rotation, and turn the device horizontally I can then access the prompts fine, the screen will slide up a bit and reveal them. Can't do this in vertical mode even with scrolling on. So, it's kind of a work around. Though way to many clicks for those of us who keep our phone rotation locked.

@3DEnthusiast
Copy link
Author

I'd bump this up to CRITICAL: I had to cancel a print a few minutes ago, and I couldn't click on the confirm button! I had to run to my desktop computer on the other side of the house to cancel properly.

I'm not sure I know how to bump it.

@stale
Copy link

stale bot commented Apr 23, 2020

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Apr 23, 2020
@CodeBrauer
Copy link

bump!

@BillyBlaze
Copy link
Owner

I looked into this issue, however I am unable to reproduce this issue.

That aside, I removed all declarations with 100vh and refactored it a bit so that the common issue with the navigation bar is gone. Can somebody confirm this for me that it also worked for them?

  1. Uninstall TouchUI
  2. Install TouchUI with the link:
    https://github.com/BillyBlaze/OctoPrint-TouchUI/archive/maintenance.zip

@Prizmagnetic
Copy link

@BillyBlaze I just tested your fix and it has resolved the issue for me. I'm using a Samsung Galaxy S9 with chrome

@BillyBlaze
Copy link
Owner

Awesome thanks for reporting. This fix has been released in latest version (0.3.15)

@3DEnthusiast
Copy link
Author

3DEnthusiast commented Aug 21, 2020 via email

@Prizmagnetic
Copy link

the issue has come back, now that I'm running 0.3.15 instead of the maintenance branch

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants